From a5bc4f388386c7f115408d472870c5be1d746b3c Mon Sep 17 00:00:00 2001
From: willemw12 <willemw12@gmail.com>
Date: Fri, 22 Nov 2024 19:55:46 +0100
Subject: [PATCH] fix: displaying selected task drag handle

---
 .../main/java/nl/mpcjanssen/simpletask/task/TaskAdapter.kt   | 2 +-
 app/src/main/res/values/strings.xml                          | 5 +++--
 app/src/main/res/xml/interface_preferences.xml               | 1 +
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/app/src/main/java/nl/mpcjanssen/simpletask/task/TaskAdapter.kt b/app/src/main/java/nl/mpcjanssen/simpletask/task/TaskAdapter.kt
index 89e3ca7b9..d5467dcba 100644
--- a/app/src/main/java/nl/mpcjanssen/simpletask/task/TaskAdapter.kt
+++ b/app/src/main/java/nl/mpcjanssen/simpletask/task/TaskAdapter.kt
@@ -333,7 +333,7 @@ class TaskAdapter(
         comp.comparator.compare(from.task, to.task)
         val comparison = comp.comparator.compare(from.task, to.task)
 
-        return comparison == 0
+        return comparison != 0
     }
 
     // Updates the UI, but avoids the red line
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index 4848b9b37..474c1e808 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -410,7 +410,8 @@ You should have received a copy of the GNU General Public License along with Tod
     <string name="lua_config_share">Share</string>
     <string name="lua_open_config">Lua config</string>
     <string name="use_uuid_title">Assign a UUID to each task</string>
-    <string name="task_drag_title">Drag tasks to reorder (BETA)</string>
+    <string name="task_drag_title">Drag tasks to reorder (experimental)</string>
+    <string name="task_drag_summary">Only some sort filters will display the reordered list.</string>
     <string name="nav_drawer_hint">Save the current filter\n
         using the save button</string>
     <string name="invalid_certificate_msg">Server certificate is invalid. Do you want to continue?</string>
@@ -426,4 +427,4 @@ You should have received a copy of the GNU General Public License along with Tod
     <string name="pin_notification">Pin as notification</string>
     <string name="channel_name">Pin notifications</string>
     <string name="channel_description">Channel for tasks pinned as notifications</string>
-</resources>
\ No newline at end of file
+</resources>
diff --git a/app/src/main/res/xml/interface_preferences.xml b/app/src/main/res/xml/interface_preferences.xml
index 3e01f21a5..c087ff6ba 100644
--- a/app/src/main/res/xml/interface_preferences.xml
+++ b/app/src/main/res/xml/interface_preferences.xml
@@ -50,5 +50,6 @@
     <CheckBoxPreference
         android:defaultValue="false"
         android:key="@string/task_drag"
+        android:summary="@string/task_drag_summary"
         android:title="@string/task_drag_title" />
 </PreferenceScreen>
\ No newline at end of file