Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate to BigDecimal #126

Open
pynixwang opened this issue Jan 19, 2018 · 4 comments
Open

migrate to BigDecimal #126

pynixwang opened this issue Jan 19, 2018 · 4 comments

Comments

@pynixwang
Copy link

crystal 0.24.1 has BigDecimal builtin.
it 's time to turn numeric/decimal column to BigDecimal
@greenbigfrog
Copy link
Contributor

If anyone could give me any pointers on where to start I'd like to attempt implementing this.

@pynixwang
Copy link
Author

@greenbigfrog

https://github.com/will/crystal-pg/blob/master/src/pg/decoder.cr#L285-L296 maybe there.

@greenbigfrog
Copy link
Contributor

Oh. Sorry for not commenting, but I've already started 😄
https://github.com/greenbigfrog/crystal-pg/tree/bigdecimal

@pynixwang
Copy link
Author

@greenbigfrog there is also UUID builtin.

@greenbigfrog greenbigfrog mentioned this issue Jan 21, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pynixwang @greenbigfrog