Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document sequence identifier requirements #30

Closed
jimrybarski opened this issue Apr 28, 2020 · 2 comments
Closed

Document sequence identifier requirements #30

jimrybarski opened this issue Apr 28, 2020 · 2 comments
Labels
documentation Improvements or additions to documentation

Comments

@jimrybarski
Copy link
Collaborator

jimrybarski commented Apr 28, 2020 •
edited
Loading

In parsers.parse_blast_xml(), the sequence identifier is implicitly expected to conform to the format: accession_id protein_name description. A sequence identifier with no spaces will throw an uncaught IndexError. However, this is not a bug, just an undocumented requirement, since CSVWriter also requires these fields to have been parsed correctly.
@jimrybarski jimrybarski added the documentation Improvements or additions to documentation label Apr 28, 2020
@jimrybarski
Copy link
Collaborator Author

That said, it might also be worth improving the error message in case someone overlooks this.

@afrubin afrubin mentioned this issue Sep 2, 2021
Closed
40 tasks
@jimrybarski
Copy link
Collaborator Author

This function no longer exists, so problem solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jimrybarski