Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for module-info.java #14

Open
matejsp opened this issue May 21, 2019 · 2 comments
Open

Support for module-info.java #14

matejsp opened this issue May 21, 2019 · 2 comments

Comments

@matejsp
Copy link

matejsp commented May 21, 2019

check style fails with: module-info.java:1:1: unexpected token: open

Based on google & sun checks you should add config to skip module-info:
https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/google_checks.xml

<!-- Excludes all 'module-info.java' files              -->
<!-- See https://checkstyle.org/config_filefilters.html -->
<module name="BeforeExecutionExclusionFileFilter">
    <property name="fileNamePattern" value="module\-info\.java$"/>
</module>
@darranl
Copy link
Contributor

darranl commented May 21, 2019

Where does check style fail with this?

@matejsp
Copy link
Author

matejsp commented May 21, 2019

We are just using this artifact/style internally. Together with jigsaw modules.
Official solution inside checkstyle project is to exclude module-info.java.

Well tbh it won't affect you until you are not starting to modularize wildfly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants