From 4ab9c74e9f3e5c2581c1abb1464c2ca2b9aec741 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Wiktor=20Niesiob=C4=99dzki?= Date: Mon, 4 Nov 2024 09:22:19 +0000 Subject: [PATCH] Review fixes --- blueprints/data-solutions/vertex-mlops/vertex.tf | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/blueprints/data-solutions/vertex-mlops/vertex.tf b/blueprints/data-solutions/vertex-mlops/vertex.tf index 32fdf84630..f8865cfbc4 100644 --- a/blueprints/data-solutions/vertex-mlops/vertex.tf +++ b/blueprints/data-solutions/vertex-mlops/vertex.tf @@ -114,6 +114,8 @@ resource "google_workbench_instance" "playground" { service_accounts { email = module.service-account-notebook.email } + # full list of supported metadata keys: + # https://cloud.google.com/vertex-ai/docs/workbench/instances/manage-metadata metadata = { notebook-disable-nbconvert = "false" notebook-disable-downloads = "false" @@ -125,12 +127,7 @@ resource "google_workbench_instance" "playground" { disable_proxy_access = true instance_owners = try(tolist(var.notebooks[each.key].owner), null) - # Remove once terraform-provider-google/issues/9164 is fixed - # lifecycle { - # ignore_changes = [disk_encryption, kms_key] - # } - #TODO Uncomment once terraform-provider-google/issues/9273 is fixed depends_on = [ google_project_iam_member.shared_vpc, ]