Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom errors should inherit js Error #7

Closed
wiktor-obrebski opened this issue Jul 21, 2022 · 0 comments
Closed

Custom errors should inherit js Error #7

wiktor-obrebski opened this issue Jul 21, 2022 · 0 comments

Comments

@wiktor-obrebski
Copy link
Owner

In some cases, especially when using .unsafePromise(), the custom domain errors can be thrown.
The function should not be used in normal application flow, but can be useful in tests.

https://mochajs.org/ test runner do not works well with throwed / rejected errors that do not inherit by Error.
This is good enough reason to change proposed error classes style in the library documentation.
Proposition of new error style:

class InvalidCredentialsError extends Error {
  name = 'InvalidCredentials' as const;
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant