Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not clear what the input TRAPI results URL should look like #4

Open
ayushi-agrawal-gladstone opened this issue Feb 9, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@ayushi-agrawal-gladstone
Copy link
Collaborator

It is not clear that a JSON TRAPI result URL is expected by the notebook as input.
Suggested solutions:

  1. In the user input widget, "TRAPI Result URL" field could be renamed to "TRAPI Result URL (JSON)"
  2. At the top of notebook, provide more details that a JSON TRAPI results URL is needed as input. This is not clear from the current description.

Reported by @khanspers

@ayushi-agrawal-gladstone ayushi-agrawal-gladstone added the enhancement New feature or request label Feb 9, 2023
@AlexanderPico
Copy link
Member

Good point. Or we could accept either, or even just the hash alone, and then construct the JSON URL?

@ayushi-agrawal-gladstone
Copy link
Collaborator Author

I like the idea of accepting either a hash or a JSON URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants