Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split off from dgraham/eslint-plugin-jquery and choose new name #58

Closed
edg2s opened this issue Jan 22, 2019 · 8 comments
Closed

Split off from dgraham/eslint-plugin-jquery and choose new name #58

edg2s opened this issue Jan 22, 2019 · 8 comments
Assignees

Comments

@edg2s
Copy link
Member

edg2s commented Jan 22, 2019

As we continue to diverge, and the dgraham/eslint-plugin-jquery project continues to bit-rot, it seems less likely we will ever merge back in, so it will probably just be better to break off and choose a unique name.

Proposals so far:

  • no-jquery
  • jq
  • avoid-jquery
  • nojq
@edg2s
Copy link
Member Author

edg2s commented Jan 22, 2019

My current preference is no-jquery, it's fairly short, descriptive (all of our rules are currently no- rules) and jq may be an abbreviation people don't understand.

@jdforrester
Copy link
Member

no-jquery works for me.

@Krinkle
Copy link
Member

Krinkle commented Jan 22, 2019

Note that if we use the @wikimedia prefix, we wouldn't have to use a different name per-se. If we do pick a different name, my only (mild) preference would be for it to not contain a dash so as to keep the convention of eslint-plugin-{name}.

@edg2s
Copy link
Member Author

edg2s commented Jan 23, 2019

The problem with the @wikimedia prefix is we have to add it to every rule exception, so you get a load of:

// eslint-disable-next-line @wikimedia/jquery/no-global-selector
$( '.myApp' )...

Also once we start cleaning up the lack of util/collection splits in more of the methods we are going to be left with a package that has less than 50% in common with upstream.

my only (mild) preference would be for it to not contain a dash so as to keep the convention of eslint-plugin-{name}.

Does eslint-plugin-no-jquery not fit with the convention and work?

@Krinkle
Copy link
Member

Krinkle commented Jan 23, 2019

Yeah, I suppose it does. Just felt like it'd be neat to avoid dashes in the name, but don't mind me :)

@jdforrester
Copy link
Member

We could call it NO!jQuery ;-)

@edg2s edg2s mentioned this issue Jan 24, 2019
@edg2s
Copy link
Member Author

edg2s commented Feb 16, 2019

I've sent a support request to have our fork status removed. Once that is actioned I'll rename this repo to eslint-plugin-no-jquery. If this somehow breaks our npm dependency chain, I'll fork it back to eslint-plugin-jquery as a temporary alias.

@edg2s
Copy link
Member Author

edg2s commented Feb 17, 2019

De-forking is done. Apparently renaming leaves behind a redirect as long as a new repo isn't created at the old name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants