Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deploy script dependencies from external not resolved when using --tags #341

Open
nataouze opened this issue Jul 1, 2022 · 2 comments · May be fixed by #492
Open

deploy script dependencies from external not resolved when using --tags #341

nataouze opened this issue Jul 1, 2022 · 2 comments · May be fixed by #492

Comments

@nataouze
Copy link
Contributor

nataouze commented Jul 1, 2022

Describe the bug
When running hardhat deploy with the --tags option, a deploy script that has a dependency on an external deploy script fails to run this dependency.

Expected behavior
The external deploy scripts should consistently be usable as dependencies, whether --tags is used or not, same as with the local deploy scripts.

Alternative to bypass the issue
Adding the dependency deploy script tag in the list of --tags correctly runs it.

versions

  • hardhat-deploy 0.11.11 (and earlier)
@nataouze
Copy link
Contributor Author

nataouze commented Dec 8, 2022

Hello, any plan to look at this issue?

@0xlucian
Copy link

Hey you can just release your external deployments as npm package, import them in your project and just import the deployment function in a deployment file and add func.tags = ["Tag"]; in this file.. Please provide some code I can help with that

@nataouze nataouze linked a pull request Oct 22, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add dependencyOnlyDeploy for external contracts config nataouze/hardhat-deploy
2 participants
@nataouze @0xlucian