You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
the type for classes is classes: List[str] = []. when it is passed a string, each character is interpreted as a separate class name.
You might want to throw an error for this because it's an easy mistake to make and will lead to unexpected results for users.
For consistency with react, you might want to rename classes as classNames.
Related
the solara.Style component is a bit confusingly named. Since the demos only show it accepting a css stylesheet path, I missed that it actually accepts a css string.
You might want to make solara.Stylesheet which inserts a css file. and solara.StyleBlock that accepts css text.
The text was updated successfully, but these errors were encountered:
the type for
classes
isclasses: List[str] = []
. when it is passed a string, each character is interpreted as a separate class name.You might want to throw an error for this because it's an easy mistake to make and will lead to unexpected results for users.
For consistency with react, you might want to rename
classes
asclassNames
.Related
the
solara.Style
component is a bit confusingly named. Since the demos only show it accepting a css stylesheet path, I missed that it actually accepts a css string.You might want to make
solara.Stylesheet
which inserts a css file. andsolara.StyleBlock
that accepts css text.The text was updated successfully, but these errors were encountered: