Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR-120] BREAKING: avoid rerender on hover for animated avatars #42

Merged
merged 3 commits into from
Oct 11, 2023
Merged

[FR-120] BREAKING: avoid rerender on hover for animated avatars #42

merged 3 commits into from
Oct 11, 2023

Conversation

JohnyTheCarrot
Copy link
Contributor

Breaking changes

- avatarUrlOverride?(user: APIUser): string | null;
+ avatarUrlOverride?(user: APIUser): UserAvatar | null;

with

export interface UserAvatar {
  stillAvatarUrl: string;
  animatedAvatarUrl?: string;
}

@JohnyTheCarrot JohnyTheCarrot changed the base branch from master to development September 27, 2023 12:26
@JohnyTheCarrot JohnyTheCarrot requested review from advaith1, a team and mason-rogers and removed request for a team September 29, 2023 07:14
@mason-rogers
Copy link
Member

conflicts here @JohnyTheCarrot

@JohnyTheCarrot JohnyTheCarrot merged commit 4d91852 into development Oct 11, 2023
@JohnyTheCarrot JohnyTheCarrot deleted the fix/FR-120 branch October 11, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mason-rogers mason-rogers mason-rogers approved these changes

@advaith1 advaith1 Awaiting requested review from advaith1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohnyTheCarrot @mason-rogers