refactor: Replace duplicate integer to CSS conversion code with fn and call to it #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnyTheCarrot
changed the title
JohnyTheCarrot
force-pushed
the
refactor/color-int-to-css
branch
2 times, most recently
from
18deeb5
to
7b5ee27
Compare
JohnyTheCarrot
force-pushed
the
refactor/color-int-to-css
branch
from
7b5ee27
to
8d9b527
Compare
JohnyTheCarrot
changed the title
Yomanz
approved these changes
Aug 11, 2023
JohnyTheCarrot
added a commit
that referenced
this pull request
Sep 5, 2023
* fix mention padding & make buttons not selectable * add support for custom chat badges * scale emojis in headers * set up vite * update storybook * fix storybook types * fix storybook style * fix some of the markdown CSS * feat: only make component ids constant in prod builds, to aid testing * fix: mentions hover css (#16) * feat: finish hooking up click handlers (#17) * [FR-57] Fix type errors (#14) * fix type errors and add eslint rule * fix more type errors and add ThreadStarterMessage message type * fix types where possible * make requested changes * fix merge errors * refactor: color int to css function (#18) * chore: update storybook (#19) * feat: support i18n * fix: fix pnpm-lock.yaml * feat: link click handlers * feat: support provider url * feat: attachment click handler (#22) * feat: add prefix to tokens to avoid shadowing (#21) * fix: syntax error in storybook (#25) * feat: fall back to default avatar in case the main one does not load (#26) * build: v2.0.0 (#27) --------- Co-authored-by: Lewis <[email protected]>
JohnyTheCarrot
added a commit
that referenced
this pull request
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.