Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stage third-party tool output in a temp directory for checking #39

Open
widdowquinn opened this issue Mar 12, 2019 · 0 comments
Open

Stage third-party tool output in a temp directory for checking #39

widdowquinn opened this issue Mar 12, 2019 · 0 comments
Assignees

Comments

@widdowquinn
Copy link
Owner

pdp makes many calls to third-party tools. With the addition of the --recovery option, after a stall/server kick, the output of these tools can be trusted without checking. This might cause future problems if the output was incomplete.

One way to avoid these problems would be to stage third-party output in a temp directory. For instance:

  • Build command line as usual, but replace output directory with a temp directory
  • Run the third-party command, and monitor the return code
  • If return code is zero, move the tool's output into the actual output directory
    • Else: raise an error and log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant