Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vgo run fails #41

Open
adam-hanna opened this issue Jul 26, 2018 · 4 comments
Open

vgo run fails #41

adam-hanna opened this issue Jul 26, 2018 · 4 comments

Comments

@adam-hanna
Copy link

Trying to run the project with vgo (which will be worked into g1.11) with vgo run main.go and am getting the following errors:

go: import "github.com/c3systems/c3-go/core/p2p/protobuff" ->
        import "github.com/c3systems/c3-go/core/miner" ->
        import "github.com/c3systems/c3-go/core/p2p" ->
        import "github.com/ipfs/go-ipfs/blockservice" ->
        import "gx/ipfs/QmTRCUvZLiir12Qr6MV3HKfKMHX8Nf1Vddn6t2g5nsQSb9/go-block-format": cannot find module providing package gx/ipfs/QmTRCUvZLiir12Qr6MV3
HKfKMHX8Nf1Vddn6t2g5nsQSb9/go-block-format

Probably related to #2

@lanzafame
Copy link

@adam-hanna technically, this isn't a gx issue. I am not sure of the reason but go-ipfs commited the gx import paths and that is what is incompatible with vgo/go get. A counter example is that vgo works perfectly with go-libp2p even though it also makes use of gx.

@adam-hanna
Copy link
Author

adam-hanna commented Jul 27, 2018

Hi @lanzafame, thanks for the quick response!

It looks like go-libp2p isn't using gx imports in their source code. However, go-ipfs regularly do.

That last link I gave is where my program is failing when running vgo. Unless I misunderstood your counter example?

@lanzafame
Copy link

Yeah, so this issue should get raised with go-ipfs to see what people are willing to do about it.

@whyrusleeping it may be a good idea, if possible, to get go-ipfs ready for go1.11 and remove the gx imports. Thoughts?

@dignifiedquire
Copy link

There is another thing that vgo needs though, and that is properly tagged releases. Currently most ipfs & libp2p modules have some release tags but not for all releases, that means vgo picks up the latest tagged release instead of the actual latest release. This would work fine if there were no tags, but having some releases tagged makes for a very inconsistent experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants