Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tales not shown until refresh on error #597

Open
ThomasThelen opened this issue Feb 20, 2020 · 2 comments
Open

Tales not shown until refresh on error #597

ThomasThelen opened this issue Feb 20, 2020 · 2 comments
Labels

Comments

@ThomasThelen
Copy link
Member

There are two symptoms, but I think that they should have solution so I'm putting them in one issue.

Issue 1

When you copy + launch a Tale, but have hit the instance cap-the Tale won't be displayed in the Tale browser until you refresh the page.

Issue 2

When you analyze in Whole Tale, but hit the instance cap-the Tale is created but not shown in the Tale browser

@ThomasThelen ThomasThelen self-assigned this Feb 20, 2020
@bodom0015
Copy link
Member

bodom0015 commented Feb 20, 2020

One lazy (yet consistent) way to handle both of these cases would be to navigate to the newly-created Tale, even though it can't be run yet.

This creates a slight problem where the user needs to navigate back to Stop another Tale before allowing them to start this one, but that navigation back would refresh the view. It would also help to at least make it a bit more clear that the Tale was created and it simply couldn't be started.

@ThomasThelen
Copy link
Member Author

If we show the Tale, it'll still be buried with all of the public ones because the user will most likely not be filtering their own. At the same time, they would be on the page where they can do everything they need to do to get their Tale running (stop one instance and start theirs).

I like the idea of redirecting them to the run page for the purposes that you brought up. @craig-willis do you want to be a third voice of reason?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants