Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logout clears local storage including lastRead value #490

Open
craig-willis opened this issue Jun 7, 2019 · 1 comment
Open

Logout clears local storage including lastRead value #490

craig-willis opened this issue Jun 7, 2019 · 1 comment

Comments

@craig-willis
Copy link
Contributor

This only happens to me intermittently in non-private sessions, but we are explicitly clearing out local storage during logout:

https://github.com/whole-tale/dashboard/blob/master/app/services/user-auth.js#L50-L68

For the new notification implementation, this means that the lastRead value is cleared on logout, resulting in the display of all notifications after logout.

Perhaps we could either clear everything except lastRead or consider adding lastRead to the user object?

@ThomasThelen
Copy link
Member

Probably related to #29. I like the idea of not clearing it on the logout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants