Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notification handling during restart #460

Open
craig-willis opened this issue Apr 12, 2019 · 1 comment
Open

Add notification handling during restart #460

craig-willis opened this issue Apr 12, 2019 · 1 comment

Comments

@craig-willis
Copy link
Contributor

PRs whole-tale/gwvolman#66 whole-tale/girder_wholetale#299 add notifications during the restart process. We need to update the UI to handle these. Note, that these are implemented using jobs, instead of having custom notifications. @Xarthisius thinks this is the best model going forward, so we should also update the build notifications to use this approach

Completion criteria:

  • UI handles notifications during restart from jobs
  • Test cases
  • Documentation
@bodom0015
Copy link
Member

I believe this has already been fixed. There are, however, still improvements we could make to the existing Updating instance implementation, such as sending back tale_id instead of instance_id

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants