Add onError option to the mountable package #632

whitphx · 2023-10-07T02:03:18Z

Resolves #628

This reverts commit 54a59e3.

* Revert "Add onError option to the mountable package (#632)" This reverts commit 54a59e3. * Fix .github/workflows/main.yml * Revert .github/workflows/main.yml * Fix type imports * Update Makefile * Fix typings in common-react/src/toastify-components/callbacks.tsx

whitphx added 2 commits October 7, 2023 11:03

Add onError option to the mountable package

1e29a19

Fix .github/workflows/main.yml

d7af394

github-actions bot deployed to stlite-sharing (Preview) October 7, 2023 02:20 View deployment

github-actions bot deployed to stlite-sharing-editor (Preview) October 7, 2023 02:24 View deployment

github-actions bot deployed to stlite-sharing (Preview) October 7, 2023 02:42 View deployment

github-actions bot deployed to stlite-sharing-editor (Preview) October 7, 2023 02:46 View deployment

whitphx added 2 commits October 7, 2023 11:51

Update Makefile

da927a1

Fix type imports

e25cf1a

github-actions bot deployed to stlite-sharing (Preview) October 7, 2023 03:14 View deployment

github-actions bot deployed to stlite-sharing-editor (Preview) October 7, 2023 03:19 View deployment

whitphx added 2 commits October 7, 2023 12:23

Mock common-react for mountable tests

e5f974a

Revert .github/workflows/main.yml

c38fa4f

github-actions bot deployed to stlite-sharing (Preview) October 7, 2023 03:41 View deployment

github-actions bot deployed to stlite-sharing-editor (Preview) October 7, 2023 03:47 View deployment

whitphx added 2 commits October 7, 2023 12:55

Add tests

55125a3

Fix typing in tests

41fa458

github-actions bot deployed to stlite-sharing (Preview) October 7, 2023 04:16 View deployment

github-actions bot deployed to stlite-sharing-editor (Preview) October 7, 2023 04:20 View deployment

github-actions bot deployed to stlite-sharing (Preview) October 7, 2023 04:41 View deployment

github-actions bot deployed to stlite-sharing-editor (Preview) October 7, 2023 04:45 View deployment

whitphx force-pushed the feature/mountable-custom-error-handler branch from c4728c9 to ab773f1 Compare October 7, 2023 04:52

Fix options.test.ts

0793f60

whitphx force-pushed the feature/mountable-custom-error-handler branch from ab773f1 to 0793f60 Compare October 7, 2023 04:53

github-actions bot deployed to stlite-sharing (Preview) October 7, 2023 05:10 View deployment

github-actions bot deployed to stlite-sharing-editor (Preview) October 7, 2023 05:15 View deployment

github-actions bot deployed to stlite-sharing (Preview) October 7, 2023 05:34 View deployment

github-actions bot deployed to stlite-sharing-editor (Preview) October 7, 2023 05:38 View deployment

whitphx merged commit 54a59e3 into main Oct 7, 2023
21 checks passed

whitphx deleted the feature/mountable-custom-error-handler branch October 7, 2023 05:42

whitphx added a commit that referenced this pull request Oct 8, 2023

Revert "Add onError option to the mountable package (#632)"

8ae8fc0

This reverts commit 54a59e3.

whitphx mentioned this pull request Oct 8, 2023

Revert "Add onError option to the mountable package" #635

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add onError option to the mountable package #632

Add onError option to the mountable package #632

whitphx commented Oct 7, 2023 •

edited

Loading

Add onError option to the mountable package #632

Add onError option to the mountable package #632

Conversation

whitphx commented Oct 7, 2023 • edited Loading

whitphx commented Oct 7, 2023 •

edited

Loading