Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Delete button is broken #513

Closed
Senexis opened this issue Mar 25, 2024 · 4 comments · Fixed by #514
Closed

Regression: Delete button is broken #513

Senexis opened this issue Mar 25, 2024 · 4 comments · Fixed by #514

Comments

@Senexis
Copy link

Senexis commented Mar 25, 2024

After the Laravel 11 compatibility pull request (#509) the delete button for deleting a block (using confirmRemove) has regressed to being broken again.

image

Currently it is not possible to delete the block due to the delete "button" no longer being an actual button.

Relevant composer show -i output:

laravel/framework                            v11.0.8
laravel/nova                                 4.33.0
whitecube/nova-flexible-content              v1.1.0
@justindantzer
Copy link

@Senexis I could be mistaken, but I believe this issue is related to a reported issue over on the Nova issue repository, and not related to the recent Laravel compatability PR.

Apparently, some components have been removed, and it is likely the <danger-button/> component used on the DeleteGroupModal.vue needs to be replaced with another component that is available.

If someone is able to throw together a PR, this may be what's required. It looks like within Nova (looking at the DeleteResourceModal.vue in the source) there is a button component used similarly to this:

import { Button } from 'laravel-nova-ui';

<Button
    type="submit"
    :loading="working"
    state="danger"
    label="Delete"
/>

@Jaspur
Copy link

Jaspur commented Apr 9, 2024

@voidgraphics can you solve this?

@voidgraphics
Copy link
Member

Yes actually, I have this scheduled for later today!

@voidgraphics voidgraphics linked a pull request Apr 9, 2024 that will close this issue
@voidgraphics
Copy link
Member

Should work now in v1.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants