Group decryption fails due PNI pending member

[hrdl-github]

Background: there's a single group that did not show up in gurk until I filtered out errors in

libsignal-service-rs/libsignal-service/src/groups_v2/operations.rs

Lines 239 to 243 in 65b51db

	let pending_members = group
	.pending_members
	.into_iter()
	.map(|m| self.decrypt_pending_member(m))
	.collect::<Result<_, _>>()?;

. In particular, the group has three pending members. The decryption of one of those fails at

libsignal-service-rs/libsignal-service/src/groups_v2/operations.rs

Line 134 in 65b51db

let aci = self.decrypt_aci(&inner_member.user_id)?;

with GroupDecodingError::NotAci. The group contains around 20 accounts that show up as "Deleted account" in the official client, which might be relevant in this case.

Tested on f99ff83.

[direc85]

Thanks for reporting!

This is another side effect of not supporting group update messages properly. I guess this bumps up the priority of it. It's been on my list for ages and I even have some code for it...

Related bug: whisperfish#706