Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attachment uploads to cdn0 are now rejected under latest Signal for ios #320

Closed
ccstolley opened this issue Sep 7, 2024 · 4 comments · Fixed by #330
Closed

Attachment uploads to cdn0 are now rejected under latest Signal for ios #320

ccstolley opened this issue Sep 7, 2024 · 4 comments · Fixed by #330
Labels
bug Something isn't working

Comments

@ccstolley
Copy link

ccstolley commented Sep 7, 2024

I noticed that Signal.app 7.26.1 (321) for ios started silently dropping my messages with attachments with this error:

2024/09/06 13:32:32:374  ❤ [AttachmentManagerImpl.swift:305 transitTierInfo(from:)]: assertionError: Invalid cdn info
2024/09/06 13:32:32:374  ❤ [MessageReceiver.swift:1144 processFlaglessDataMessage(_:request:thread:tx:)]: Could not build attachments!

Looking at the app code, it looks like ios no longer tolerates attachments that have been uploaded to cdn0:

https://github.com/signalapp/Signal-iOS/blob/7a19cb5ac898b8d5544ef3fae514b43de05182d5/SignalServiceKit/Messages/Attachments/V2/AttachmentManager/AttachmentManagerImpl.swift#L305-L308

As libsignal-server-rs only supports cdn0 currently, we'll need to add support for cdn2 and cdn3 for attachments to work going forward.

@rubdos rubdos added the bug Something isn't working label Sep 8, 2024
@rubdos
Copy link
Member

rubdos commented Sep 8, 2024

Thanks for making us aware! We should've implemented attachment v3 (#34) long ago...

@gferon
Copy link
Collaborator

gferon commented Sep 8, 2024

I volunteer 😄 I have time next week!

@rubdos
Copy link
Member

rubdos commented Sep 8, 2024

I volunteer 😄 I have time next week!

I have time to read your patches, keep me in the loop! :-)

@EcoloSweet
Copy link

EcoloSweet commented Oct 9, 2024

Indeed, iOS users no longer receive attachments sent by libsignal-service-rs (on cdn0)

Worse, they are not notified of the failure, the attachment is silently dropped on client-side after the attachment is received

@gferon gferon mentioned this issue Oct 15, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants