Merge pull request #285 from whisperfish/aci-pni #879
GitHub Actions / clippy
succeeded
Mar 29, 2024 in 0s
clippy
3 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 3 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.77.0 (aedd173a2 2024-03-17)
- cargo 1.77.0 (3fe68eabf 2024-02-29)
- clippy 0.1.77 (aedd173 2024-03-17)
Annotations
Check warning on line 184 in libsignal-service/src/cipher.rs
github-actions / clippy
the function `message_decrypt_prekey` doesn't need a mutable reference
warning: the function `message_decrypt_prekey` doesn't need a mutable reference
--> libsignal-service/src/cipher.rs:184:21
|
184 | &mut self.protocol_store.clone(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
= note: `#[warn(clippy::unnecessary_mut_passed)]` on by default
Check warning on line 730 in libsignal-service/src/account_manager.rs
github-actions / clippy
called `is_none()` after searching an `Iterator` with `find`
warning: called `is_none()` after searching an `Iterator` with `find`
--> libsignal-service/src/account_manager.rs:727:24
|
727 | if pni_registration_ids
| ________________________^
728 | | .iter()
729 | | .find(|(_k, v)| **v == regid)
730 | | .is_none()
| |__________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some
= note: `#[warn(clippy::search_is_some)]` on by default
help: consider using
|
727 ~ if !pni_registration_ids
728 + .iter().any(|(_k, v)| **v == regid)
|
Check warning on line 333 in libsignal-service/src/groups_v2/manager.rs
github-actions / clippy
use of deprecated method `chrono::NaiveDateTime::timestamp`: use `.and_utc().timestamp()` instead
warning: use of deprecated method `chrono::NaiveDateTime::timestamp`: use `.and_utc().timestamp()` instead
--> libsignal-service/src/groups_v2/manager.rs:333:14
|
333 | .timestamp() as u64
| ^^^^^^^^^
|
= note: `#[warn(deprecated)]` on by default
Loading