ERROR: stopping task which is already stopped #59

aereaux · 2016-10-29T17:50:19Z

When ripping a certain track, I get this error:

ERROR: stopping task which is already stopped
  File "/usr/bin/rip", line 11, in <module>
    load_entry_point('whipper==0.3.0', 'console_scripts', 'rip')()
  File "/usr/lib/python2.7/site-packages/morituri/rip/main.py", line 22, in main
    ret = c.parse(sys.argv[1:])
  File "/usr/lib/python2.7/site-packages/morituri/rip/main.py", line 89, in parse
    logcommand.LogCommand.parse(self, argv)
  File "/usr/lib/python2.7/site-packages/morituri/common/logcommand.py", line 62, in parse
    command.Command.parse(self, argv)
  File "/usr/lib/python2.7/site-packages/morituri/extern/command/command.py", line 401, in parse
    return self.subCommands[command].parse(args[1:])
  File "/usr/lib/python2.7/site-packages/morituri/common/logcommand.py", line 62, in parse
    command.Command.parse(self, argv)
  File "/usr/lib/python2.7/site-packages/morituri/extern/command/command.py", line 401, in parse
    return self.subCommands[command].parse(args[1:])
  File "/usr/lib/python2.7/site-packages/morituri/common/logcommand.py", line 62, in parse
    command.Command.parse(self, argv)
  File "/usr/lib/python2.7/site-packages/morituri/extern/command/command.py", line 363, in parse
    ret = self.do(args)
  File "/usr/lib/python2.7/site-packages/morituri/rip/cd.py", line 174, in do
    self.doCommand()
  File "/usr/lib/python2.7/site-packages/morituri/rip/cd.py", line 482, in doCommand
    ripIfNotRipped(i + 1)
  File "/usr/lib/python2.7/site-packages/morituri/rip/cd.py", line 414, in ripIfNotRipped
    number, len(self.itable.tracks), extra))
  File "/usr/lib/python2.7/site-packages/morituri/common/program.py", line 603, in ripTrack
    runner.run(t)
  File "/usr/lib/python2.7/site-packages/morituri/extern/task/task.py", line 479, in run
    self._loop.run()
  File "/usr/lib/python2.7/site-packages/morituri/extern/task/task.py", line 511, in c
    callable(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/morituri/extern/task/gstreamer.py", line 151, in stop
    task.Task.stop(self)
  File "/usr/lib/python2.7/site-packages/morituri/extern/task/task.py", line 154, in stop
    import traceback; traceback.print_stack()

It happens multiple times, when the ripper retries.

RecursiveForest · 2016-11-01T01:05:50Z

Can you:

RIP_DEBUG=5 rip cd rip > whipper.log 2>&1
gzip whipper.log

And upload the log?

aereaux · 2016-11-01T02:25:50Z

whipper.log.gz

stochashtic · 2016-11-13T11:21:30Z

Just installed whipper and having the same error on all cds that I try. I used to use the old morituri package.

Ripping track 1 of 16: 01. Steven Wright - And Now Little Green Bag….flac
Ripping track 1 of 16 (try 2): 01. Steven Wright - And Now Little Green Bag….flac
ERROR: stopping task which is already stopped
  File "/usr/bin/whipper", line 9, in <module>
    load_entry_point('whipper==0.4.0', 'console_scripts', 'whipper')()
  File "/usr/lib/python2.7/site-packages/whipper-0.4.0-py2.7.egg/morituri/rip/main.py", line 27, in main
    ret = c.parse(sys.argv[1:])
  File "/usr/lib/python2.7/site-packages/whipper-0.4.0-py2.7.egg/morituri/rip/main.py", line 94, in parse
    logcommand.LogCommand.parse(self, argv)
  File "/usr/lib/python2.7/site-packages/whipper-0.4.0-py2.7.egg/morituri/common/logcommand.py", line 62, in parse
    command.Command.parse(self, argv)
  File "/usr/lib/python2.7/site-packages/whipper-0.4.0-py2.7.egg/morituri/extern/command/command.py", line 401, in parse
    return self.subCommands[command].parse(args[1:])
  File "/usr/lib/python2.7/site-packages/whipper-0.4.0-py2.7.egg/morituri/common/logcommand.py", line 62, in parse
    command.Command.parse(self, argv)
  File "/usr/lib/python2.7/site-packages/whipper-0.4.0-py2.7.egg/morituri/extern/command/command.py", line 401, in parse
    return self.subCommands[command].parse(args[1:])
  File "/usr/lib/python2.7/site-packages/whipper-0.4.0-py2.7.egg/morituri/common/logcommand.py", line 62, in parse
    command.Command.parse(self, argv)
  File "/usr/lib/python2.7/site-packages/whipper-0.4.0-py2.7.egg/morituri/extern/command/command.py", line 363, in parse
    ret = self.do(args)
  File "/usr/lib/python2.7/site-packages/whipper-0.4.0-py2.7.egg/morituri/rip/cd.py", line 174, in do
    self.doCommand()
  File "/usr/lib/python2.7/site-packages/whipper-0.4.0-py2.7.egg/morituri/rip/cd.py", line 485, in doCommand
    ripIfNotRipped(i + 1)
  File "/usr/lib/python2.7/site-packages/whipper-0.4.0-py2.7.egg/morituri/rip/cd.py", line 414, in ripIfNotRipped
    number, len(self.itable.tracks), extra))
  File "/usr/lib/python2.7/site-packages/whipper-0.4.0-py2.7.egg/morituri/common/program.py", line 603, in ripTrack
    runner.run(t)
  File "/usr/lib/python2.7/site-packages/whipper-0.4.0-py2.7.egg/morituri/extern/task/task.py", line 479, in run
    self._loop.run()
  File "/usr/lib/python2.7/site-packages/whipper-0.4.0-py2.7.egg/morituri/extern/task/task.py", line 511, in c
    callable(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/whipper-0.4.0-py2.7.egg/morituri/extern/task/gstreamer.py", line 151, in stop
    task.Task.stop(self)
  File "/usr/lib/python2.7/site-packages/whipper-0.4.0-py2.7.egg/morituri/extern/task/task.py", line 157, in stop
    self._notifyListeners('stopped')
  File "/usr/lib/python2.7/site-packages/whipper-0.4.0-py2.7.egg/morituri/extern/task/task.py", line 237, in _notifyListeners
    method(self, *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/whipper-0.4.0-py2.7.egg/morituri/extern/task/task.py", line 373, in stopped
    self.stop()
  File "/usr/lib/python2.7/site-packages/whipper-0.4.0-py2.7.egg/morituri/program/cdparanoia.py", line 548, in stop
    task.MultiSeparateTask.stop(self)
  File "/usr/lib/python2.7/site-packages/whipper-0.4.0-py2.7.egg/morituri/extern/task/task.py", line 154, in stop
    import traceback; traceback.print_stack()
Ripping track 1 of 16 (try 3): 01. Steven Wright - And Now Little Green Bag….flac
Ripping track 1 of 16 (try 4): 01. Steven Wright - And Now Little Green Bag….flac
ERROR: stopping task which is already stopped
  File "/usr/bin/whipper", line 9, in <module>
    load_entry_point('whipper==0.4.0', 'console_scripts', 'whipper')()
  File "/usr/lib/python2.7/site-packages/whipper-0.4.0-py2.7.egg/morituri/rip/main.py", line 27, in main
    ret = c.parse(sys.argv[1:])
  File "/usr/lib/python2.7/site-packages/whipper-0.4.0-py2.7.egg/morituri/rip/main.py", line 94, in parse
    logcommand.LogCommand.parse(self, argv)
  File "/usr/lib/python2.7/site-packages/whipper-0.4.0-py2.7.egg/morituri/common/logcommand.py", line 62, in parse
    command.Command.parse(self, argv)
  File "/usr/lib/python2.7/site-packages/whipper-0.4.0-py2.7.egg/morituri/extern/command/command.py", line 401, in parse
    return self.subCommands[command].parse(args[1:])
  File "/usr/lib/python2.7/site-packages/whipper-0.4.0-py2.7.egg/morituri/common/logcommand.py", line 62, in parse
    command.Command.parse(self, argv)
  File "/usr/lib/python2.7/site-packages/whipper-0.4.0-py2.7.egg/morituri/extern/command/command.py", line 401, in parse
    return self.subCommands[command].parse(args[1:])
  File "/usr/lib/python2.7/site-packages/whipper-0.4.0-py2.7.egg/morituri/common/logcommand.py", line 62, in parse
    command.Command.parse(self, argv)
  File "/usr/lib/python2.7/site-packages/whipper-0.4.0-py2.7.egg/morituri/extern/command/command.py", line 363, in parse
    ret = self.do(args)
  File "/usr/lib/python2.7/site-packages/whipper-0.4.0-py2.7.egg/morituri/rip/cd.py", line 174, in do
    self.doCommand()
  File "/usr/lib/python2.7/site-packages/whipper-0.4.0-py2.7.egg/morituri/rip/cd.py", line 485, in doCommand
    ripIfNotRipped(i + 1)
  File "/usr/lib/python2.7/site-packages/whipper-0.4.0-py2.7.egg/morituri/rip/cd.py", line 414, in ripIfNotRipped
    number, len(self.itable.tracks), extra))
  File "/usr/lib/python2.7/site-packages/whipper-0.4.0-py2.7.egg/morituri/common/program.py", line 603, in ripTrack
    runner.run(t)
  File "/usr/lib/python2.7/site-packages/whipper-0.4.0-py2.7.egg/morituri/extern/task/task.py", line 479, in run
    self._loop.run()
  File "/usr/lib/python2.7/site-packages/whipper-0.4.0-py2.7.egg/morituri/extern/task/task.py", line 511, in c
    callable(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/whipper-0.4.0-py2.7.egg/morituri/extern/task/gstreamer.py", line 151, in stop
    task.Task.stop(self)
  File "/usr/lib/python2.7/site-packages/whipper-0.4.0-py2.7.egg/morituri/extern/task/task.py", line 157, in stop
    self._notifyListeners('stopped')
  File "/usr/lib/python2.7/site-packages/whipper-0.4.0-py2.7.egg/morituri/extern/task/task.py", line 237, in _notifyListeners
    method(self, *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/whipper-0.4.0-py2.7.egg/morituri/extern/task/task.py", line 373, in stopped
    self.stop()
  File "/usr/lib/python2.7/site-packages/whipper-0.4.0-py2.7.egg/morituri/program/cdparanoia.py", line 548, in stop
    task.MultiSeparateTask.stop(self)
  File "/usr/lib/python2.7/site-packages/whipper-0.4.0-py2.7.egg/morituri/extern/task/task.py", line 154, in stop
    import traceback; traceback.print_stack()
Ripping track 1 of 16 (try 5): 01. Steven Wright - And Now Little Green Bag….flac
ERROR [ 4862] "rip"                            rip               Nov 13 11:53:11      Giving up on track 1 after 5 times (morituri/rip/cd.py:423)
Giving up on track 1 after 5 times

Debug logfile:
whipper.log.gz

Look forward to the fix. Thanks.

aereaux · 2016-11-13T17:54:17Z

As far as I can tell, this only happens with one cd (on one particular track) for me. It's not identified with MusicBrainz, but it's this on freedb, and it's the second disc of this cd. It happens wuth the 9th track.

stochashtic · 2016-11-14T06:42:00Z

I haven't compared our debug logs, so maybe mine is a different cause. But I am unable to rip any CD. I can move this to a new thread if advised as such by the developers.

JoeLametta · 2016-11-17T21:37:17Z

Thanks for the bug reports.

Unfortunately I still haven't got the time to analyze the logfiles (which are really verbose^). I'll post again in case of any updates.

Something which is not so clear is if this issue happens only using whipper or it affects morituri too.

^ The logger function is going to be completely rewritten to provide more meaningful data.

aereaux · 2016-11-17T21:47:29Z

It also happens for me using morituri.

JoeLametta · 2016-11-17T22:00:21Z

It also happens for me using morituri.

OK, same error message (ERROR: stopping task which is already stopped), right?

aereaux · 2016-11-17T22:05:13Z

Yeah. In case it matters, it happened while doing rip offset find, and it left a whole bunch of cd-paranoia processes around (I assume because it tried a bunch of other offsets after finding the first one failed).

JoeLametta · 2017-01-16T21:25:31Z

@aereaux @stochashtic

Could you repost the logfiles using an updated version of whipper (following these instructions)?

Thanks

aereaux · 2017-01-16T22:32:54Z

Here are the updated logs. I am using whipper 0.4.2-1 from the arch linux AUR.
whipper.log.gz

JoeLametta · 2017-01-17T09:08:45Z

Here are the updated logs. I am using whipper 0.4.2-1 from the arch linux AUR.

From a quick review it seems to me that this bug may be related to GStreamer usage in whipper (which is scheduled for removal, will be done soon™). So my suggestion is to wait until that removal has been completed, then check if the issue still affects whipper.

Thanks

PS: #101 too seems to be related to the same issue.

JoeLametta · 2017-04-24T18:43:04Z

@aereaux @stochashtic

GStreamer has been dropped.
Could you try testing if this issue still occurs using whipper's latest version?

Thanks in advance,

Joe

aereaux · 2017-04-24T18:54:18Z

The error I get now is this:

Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/morituri/extern/task/task.py", line 511, in c
    callable(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/morituri/common/checksum.py", line 49, in _crc32
    w = wave.open(self.path)
  File "/usr/lib/python2.7/wave.py", line 511, in open
    return Wave_read(f)
  File "/usr/lib/python2.7/wave.py", line 164, in __init__
    self.initfp(f)
  File "/usr/lib/python2.7/wave.py", line 131, in initfp
    raise Error, 'file does not start with RIFF id'
wave.Error: file does not start with RIFF id
exception Error at /usr/lib/python2.7/wave.py:131: initfp(): file does not start with RIFF id
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/morituri/extern/task/task.py", line 511, in c
    callable(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/morituri/common/checksum.py", line 49, in _crc32
    w = wave.open(self.path)
  File "/usr/lib/python2.7/wave.py", line 511, in open
    return Wave_read(f)
  File "/usr/lib/python2.7/wave.py", line 164, in __init__
    self.initfp(f)
  File "/usr/lib/python2.7/wave.py", line 131, in initfp
    raise Error, 'file does not start with RIFF id'
Error: file does not start with RIFF id

JoeLametta · 2017-04-24T19:04:04Z

The error I get now is this:

Thanks, could you also provide a debug logfile (instructions HERE)?

aereaux · 2017-04-24T19:09:55Z

Here. This was done using commit 17b70ce.
whipper.log.gz

stochashtic · 2017-05-21T05:38:15Z

Works fine for me now.

aereaux · 2017-05-21T06:02:25Z

@stochashtic What version are you using?

stochashtic · 2017-05-21T08:58:29Z

Sorry, I am using commit 5b2639a

aereaux · 2017-05-21T14:13:30Z

Unfortunately I still get the RIFF id error with the most recent git commit (gb331f53)

aereaux · 2017-08-22T15:14:51Z

I think that the RIFF id is a separate problem (#136). As far as I can tell, the original problem is fixed, so I'm closing this.

JoeLametta added the Bug Generic bug: can be used together with more specific labels label Nov 5, 2016

aereaux closed this as completed Aug 22, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ERROR: stopping task which is already stopped #59

ERROR: stopping task which is already stopped #59

aereaux commented Oct 29, 2016 •

edited by JoeLametta

Loading

RecursiveForest commented Nov 1, 2016 •

edited

Loading

aereaux commented Nov 1, 2016

stochashtic commented Nov 13, 2016 •

edited

Loading

aereaux commented Nov 13, 2016

stochashtic commented Nov 14, 2016

JoeLametta commented Nov 17, 2016

aereaux commented Nov 17, 2016

JoeLametta commented Nov 17, 2016

aereaux commented Nov 17, 2016

JoeLametta commented Jan 16, 2017

aereaux commented Jan 16, 2017

JoeLametta commented Jan 17, 2017

JoeLametta commented Apr 24, 2017

aereaux commented Apr 24, 2017

JoeLametta commented Apr 24, 2017

aereaux commented Apr 24, 2017

stochashtic commented May 21, 2017

aereaux commented May 21, 2017

stochashtic commented May 21, 2017 •

edited

Loading

aereaux commented May 21, 2017

aereaux commented Aug 22, 2017

ERROR: stopping task which is already stopped #59

ERROR: stopping task which is already stopped #59

Comments

aereaux commented Oct 29, 2016 • edited by JoeLametta Loading

RecursiveForest commented Nov 1, 2016 • edited Loading

aereaux commented Nov 1, 2016

stochashtic commented Nov 13, 2016 • edited Loading

aereaux commented Nov 13, 2016

stochashtic commented Nov 14, 2016

JoeLametta commented Nov 17, 2016

aereaux commented Nov 17, 2016

JoeLametta commented Nov 17, 2016

aereaux commented Nov 17, 2016

JoeLametta commented Jan 16, 2017

aereaux commented Jan 16, 2017

JoeLametta commented Jan 17, 2017

JoeLametta commented Apr 24, 2017

aereaux commented Apr 24, 2017

JoeLametta commented Apr 24, 2017

aereaux commented Apr 24, 2017

stochashtic commented May 21, 2017

aereaux commented May 21, 2017

stochashtic commented May 21, 2017 • edited Loading

aereaux commented May 21, 2017

aereaux commented Aug 22, 2017

aereaux commented Oct 29, 2016 •

edited by JoeLametta

Loading

RecursiveForest commented Nov 1, 2016 •

edited

Loading

stochashtic commented Nov 13, 2016 •

edited

Loading

stochashtic commented May 21, 2017 •

edited

Loading