Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WARNING:whipper.command.main:set_hostname() takes 1 positional argument but 2 were given #464

Closed
texneus opened this issue Feb 8, 2020 · 2 comments
Labels
Accepted Accepted issue on our roadmap Bug Generic bug: can be used together with more specific labels Design Design or UX/UI related Improvement Minor improvement to code
Milestone

Comments

@texneus
Copy link

texneus commented Feb 8, 2020

I am getting subject warning immediately each time whipper is run. Command parameters do not seem to matter. Seems harmless (everything still appears to work) but don't see it reported so I'm not sure if I'm the only one? I'm running 0.9.0 pulled and built from Git as per the README.MD in MX Linux 19.

Ex:

$ whipper
WARNING:whipper.command.main:set_hostname() takes 1 positional argument but 2 were given
usage: whipper [-R] [-v] [-h] [-e {never,failure,success,always}]

whipper is a CD ripping utility focusing on accuracy over speed.

whipper gives you a tree of subcommands to work with.
You can get help on subcommands by using the -h option to the subcommand.

optional arguments:
  -R, --record          record API requests for playback
  -v, --version         show version information
  -h, --help            show this help message and exit
  -e {never,failure,success,always}, --eject {never,failure,success,always}
                        when to eject disc (default: success)

commands:
  accurip  handle AccurateRip information
  cd       handle CDs
  drive    handle drives
  image    handle images
  mblookup lookup MusicBrainz entry
  offset   handle drive offsets
@ABCbum
Copy link
Contributor

ABCbum commented Feb 8, 2020

Hi @texneus , this is happening due to your local version of musicbrainzngs is < 0.7 which doesn't support using https (check out this code.)

logger.warning(e)

I think maybe whipper should give a better warning message.

@JoeLametta JoeLametta added Accepted Accepted issue on our roadmap Bug Generic bug: can be used together with more specific labels Design Design or UX/UI related Improvement Minor improvement to code labels Feb 9, 2020
@JoeLametta
Copy link
Collaborator

Thanks for reporting this issue. Yeah, this is harmless unless you define a custom MusicBrainz server which is HTTPS only.
The issue should now be fixed (clearer warning) with commit 9a0b911.

@JoeLametta JoeLametta added this to the 1.0 milestone Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Bug Generic bug: can be used together with more specific labels Design Design or UX/UI related Improvement Minor improvement to code
Projects
None yet
Development

No branches or pull requests

3 participants