Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output directory isn't read #441

Closed
kroeckx opened this issue Jan 1, 2020 · 3 comments
Closed

output directory isn't read #441

kroeckx opened this issue Jan 1, 2020 · 3 comments
Assignees
Labels
Accepted Accepted issue on our roadmap Bug Generic bug: can be used together with more specific labels Priority: medium Medium priority Regression Bug that breaks functionality known to work in previous releases
Milestone

Comments

@kroeckx
Copy link

kroeckx commented Jan 1, 2020

With a current git develop snapshot, it doesn't seem to take the output_directory from the config file into account.

I'm running:
python3 -m whipper cd rip

~/.config/whipper/whipper.conf contains this section:
[whipper.cd.rip]
unknown = True
output_directory = /kurt/kurt/music-rip/

But the output is in ./album/

@github-actions
Copy link

github-actions bot commented Jan 1, 2020

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing instructions.

@myuhe
Copy link

myuhe commented Jan 15, 2020

Same issue occurred.
run
whipper cd rip --output-directory='/home/foo/music/'

then
output directory is in root directory.

environment:
ArchLinux
Python 3.8.1
whipper0.9.0

@JoeLametta JoeLametta added Accepted Accepted issue on our roadmap Bug Generic bug: can be used together with more specific labels Priority: medium Medium priority Regression Bug that breaks functionality known to work in previous releases labels Jan 15, 2020
@JoeLametta JoeLametta added this to the 1.0 milestone Jan 15, 2020
@JoeLametta JoeLametta self-assigned this Sep 24, 2020
@JoeLametta
Copy link
Collaborator

I think this bug isn't present anymore in whipper's develop branch codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Bug Generic bug: can be used together with more specific labels Priority: medium Medium priority Regression Bug that breaks functionality known to work in previous releases
Projects
None yet
Development

No branches or pull requests

3 participants