Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix addon to work with ember 2.10.0 and above #87

Closed
ajile opened this issue Dec 12, 2016 · 1 comment
Closed

Fix addon to work with ember 2.10.0 and above #87

ajile opened this issue Dec 12, 2016 · 1 comment
Labels

Comments

@ajile
Copy link
Contributor

ajile commented Dec 12, 2016

I've ran into the problem of using ember-dialog with [email protected]. Seems the Ember Component does not have template property anymore, and the dialogs show up without body. While with the previous version of [email protected] it works fine.

You may reproduce the problem so:

app/components/foo-bar.js

import Ember from "ember";
import hbs from 'htmlbars-inline-precompile';

Ember.Component.extend({
  template: hbs`A TEMPLATE`
})

app/components/foo-bar.hbs

BEGIN {{yield}} END

Ember v2.9.1 will output: BEGIN A TEMPLATE END, but Ember v2.10.10 will output: BEGIN END

@waleedq
Copy link
Contributor

waleedq commented Dec 12, 2016

I've created a new issue regarding the template property in ember.js here is a link for that emberjs/ember.js#14713, let's see what API changes that caused this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants