Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we want to add writer.waitForDesiredSize() in addition to writer.ready? #493

Open
domenic opened this issue Aug 4, 2016 · 1 comment
Milestone

Comments

@domenic
Copy link
Member

domenic commented Aug 4, 2016

In #488 we are keeping the ready promise as a simple writer.ready.

In #318 we talked about more complicated methods, like .waitForDesiredSize(n). (There were lots of options.) After some discussion in person I think we would prefer to just have a single simple promise for now; the need for allowing arbitrary waits is not clear.

However, there is an option of switching from .ready to .waitForDesiredSize() (no arguments), which would in the future allow new abilities by adding arguments.

If we don't make this switch, and in the future want to add more precise options, then the worst thing that happens is that we have two somewhat-redundant/confusing ways of checking the backpressure status: .ready vs. .waitForDesiredSize(). That is not a big deal. So maybe it is fine.

@domenic
Copy link
Member Author

domenic commented Oct 24, 2016

After living with .ready for a few months, I think we can conclude that it's pretty good as-is. If we see a need for .waitForDesiredSize(n) later, we can add that as an addition. So, let me rename this issue.

@domenic domenic changed the title Decide whether writer.ready should become writer.waitForDesiredSize() Do we want to add writer.waitForDesiredSize() in addition to writer.ready? Oct 24, 2016
@domenic domenic modified the milestone: V2 Mar 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant