Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand CONTRIBUTING on how to make things easy for reviewers #170

Open
annevk opened this issue May 19, 2020 · 0 comments
Open

Expand CONTRIBUTING on how to make things easy for reviewers #170

annevk opened this issue May 19, 2020 · 0 comments

Comments

@annevk
Copy link
Member

annevk commented May 19, 2020

https://github.com/whatwg/meta/blob/master/CONTRIBUTING.md#pull-requests should say something about how to make it easier for reviewers to follow what is happening. This is what I wrote elsewhere on that topic:

For ease of review I'd greatly appreciate two things: 1) Resolve addressed feedback so it's clear what is considered done (the reviewer can reopen if there's disagreement). I've taken the liberty of resolving most. 2) Use fixup commits as these make it very clear to the reviewer how a set of comments got resolved. We can always squash near the end. If rebasing is needed due to conflicts I would recommend rebasing first and then addressing feedback on top as subsequent commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant