Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve clarity in link and style sheet resource fetching #3544

Closed
wants to merge 4 commits into from

Commits on Apr 4, 2018

  1. Improve clarity in link and style sheet resource fetching

    * Defines the critical subresources for CSS as @imported style sheets, including
      indirectly imported ones. This was previously defined nowhere; probably it
      should live in CSS, but for now it lives here.
    * Makes it clearer that the steps to obtain the resource are the default steps,
      which some link types override.
    * Adds explicit steps for fetching critical subresources, and ties those to the
      load/error events.
    * Uses fetch primitives like network error and ok status instead of vague
      language.
    * Makes it clearer how incorrect Content-Types for CSS generate error events, by
      defining the new "resource-specific fetch error" concept.
    * Makes it clearer that resources apply if and only if their main fetch
      succeeds. (Critical subresource fetches generate error events, but do not
      impact the "obtained successfully" or "apply" concepts.)
    
    Fixes #3532.
    domenic committed Apr 4, 2018
    Configuration menu
    Copy the full SHA
    a913b6e View commit details
    Browse the repository at this point in the history
  2. Address most feedback

    domenic committed Apr 4, 2018
    Configuration menu
    Copy the full SHA
    50c4168 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2018

  1. Fix the easy things

    This will also fix #3610
    domenic committed Apr 5, 2018
    Configuration menu
    Copy the full SHA
    0448bd2 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2018

  1. Configuration menu
    Copy the full SHA
    f61f9e0 View commit details
    Browse the repository at this point in the history