Expose some NavigatorID members only on Window #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The set of attributes with [Exposed=Window] is the union of attributes NOT exposed on Worker in shipping browsers: Blink: productSub, vendor, vendorSub Edge: appCodeName Gecko: productSub, vendor, vendorSub WebKit: appCodeName, product, productSub, vendor, vendorSub Fixes #216
|
It almost seems more economical to annotate them the other way around. But anyway, LGTM. |
|
Yeah, it's 4 vs. 5, and looking at the whole set of NavigatorFoo, |
foolip
force-pushed
the
navigator-exposed
branch
from
1b1ab95 to
4a97ada
Compare
|
I flipped things around, sanity check please? |
|
Seems alright, though now you've made this I think the original might have been better. Relying on the default |
foolip
force-pushed
the
navigator-exposed
branch
from
4a97ada to
1b1ab95
Compare
|
Pushing the original commit to master, then :) |
foolip
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 6, 2016
foolip
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 6, 2016
domenic
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 10, 2016
nathaneliason
pushed a commit
to nathaneliason/html
that referenced
this pull request
Jun 16, 2022
Fixes whatwg#218. See whatwg#220 for migrating to Python 3, the better long-term fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The set of attributes with [Exposed=Window] is the union of attributes
NOT exposed on Worker in shipping browsers:
Blink: productSub, vendor, vendorSub
Edge: appCodeName
Gecko: productSub, vendor, vendorSub
WebKit: appCodeName, product, productSub, vendor, vendorSub
Fixes #216