Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accidental reverts by navigation and session history rewrite #8491

Closed
zcorpan opened this issue Nov 10, 2022 · 3 comments
Closed

Accidental reverts by navigation and session history rewrite #8491

zcorpan opened this issue Nov 10, 2022 · 3 comments

Comments

@zcorpan
Copy link
Member

zcorpan commented Nov 10, 2022

I noticed that #8428 now has a merge conflict caused by #6315

current HEAD

   <li><p><!--FETCH--><span data-x="concept-fetch">Fetch</span> <var>request</var>. This must
   <span>delay the load event</span> of the element's <span>node document</span>.</p></li>

base for #8428

   <!--FETCH--><li><p><span data-x="concept-fetch">Fetch</span> <var>request</var>, with
   <i data-x="processResponseEndOfBody">processResponseEndOfBody</i> given
   <span data-x="concept-response">response</span> <var>res</var> set to
   <span>finalize and report timing</span> with <var>res</var>, the element's
   <span>node document</span>'s <span>relevant global object</span>, and
   "<code data-x="">video</code>". This must <span>delay the load event</span> of the element's
   <span>node document</span>.</p></li>

Running git blame -L for that line for commit c196f1b (the commit preceding navigation and session history rewrite), I see #7539 by @noamr, part of issue #6542.

So it looks like the resource timing entry change for poster was accidentally reverted by #6315. Possibly others as well?

cc @domenic @jakearchibald @domfarolino

@noamr
Copy link
Contributor

noamr commented Nov 10, 2022

This is intentional! Now fetch does the resource timing reporting if it gets an initiatorType with the request so the HTML spec doesn't have to do this manually. See #7722 and whatwg/fetch#1413.

@zcorpan
Copy link
Member Author

zcorpan commented Nov 10, 2022

@noamr ah, great! Sorry for the false alarm. 🙂

@zcorpan zcorpan closed this as completed Nov 10, 2022
@noamr
Copy link
Contributor

noamr commented Nov 10, 2022

@noamr ah, great! Sorry for the false alarm. 🙂

No worries, glad you're alert about this kind of thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants