Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable SharedArrayBuffer for BroadcastChannel? #3759

Closed
annevk opened this issue Jun 14, 2018 · 4 comments
Closed

Disable SharedArrayBuffer for BroadcastChannel? #3759

annevk opened this issue Jun 14, 2018 · 4 comments

Comments

@annevk
Copy link
Member

annevk commented Jun 14, 2018

@mystor raised a good point that supporting SharedArrayBuffer in BroadcastChannel puts pressure on really getting the "agent cluster" definition correct. E.g., if you put two same-origin tabs in the same agent cluster, they can suddenly share memory, even if they cannot synchronously access each other. That seems bad and given that it's rather error prone, perhaps we're better off disabling SharedArrayBuffer there?

@domenic
Copy link
Member

domenic commented Jun 14, 2018

E.g., if you put two same-origin tabs in the same agent cluster, they can suddenly share memory, even if they cannot synchronously access each other.

How would this happen? It doesn't seem to fit with the current definition of agent cluster.

@annevk
Copy link
Member Author

annevk commented Jun 14, 2018

So the example that came up is if we add the isolation header and you have Isolated A -> B -> Isolated A'. Are A and A' in different clusters? It'd only be observable through this. I guess we could continue to allow it, if we're very careful, but the fact that you have to specifically think about BroadcastChannel reach besides stuff that can directly reach each other (or not) seems dangerous.

@domenic
Copy link
Member

domenic commented Jun 25, 2018

I'm not too worried myself. I think we should indeed strive to get the agent cluster definition correct, but if we don't, the natural process boundaries in implementations will lead us to discover the mismatch pretty quickly. (As long as we maintain the usual discipline for writing tests and such.)

@domenic
Copy link
Member

domenic commented Aug 31, 2018

Closing this as some people are being misled into thinking that it's an open question how BroadcastChannel and SharedArrayBuffers interact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants