Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

importScripts() wants a side-effect free version of "create a script" #193

Closed
annevk opened this issue Sep 24, 2015 · 1 comment
Closed

importScripts() wants a side-effect free version of "create a script" #193

annevk opened this issue Sep 24, 2015 · 1 comment
Assignees
@domenic

Comments

@annevk
Copy link
Member

annevk commented Sep 24, 2015

I'm not a 100% sure still, but the more I read, the more it seems like "create a script" has a side effect in step 7. It invokes "report an error" which ends up dispatching an event of sorts on the global.

However, importScripts() seems to expect it to rethrow.

This came up in #166 which does some refactoring in that general area.
@domenic domenic self-assigned this Dec 15, 2015
@domenic
Copy link
Member

domenic commented Dec 15, 2015

This is quite interesting. I'll work on this in #401. It looks like both the current setup and #401 are not well adapted for importScripts.

domenic added a commit that referenced this issue Dec 15, 2015
@domenic
Fix importScripts() script execution
0cd82d3 
This fixes #193, which notes that importScripts() previously sent errors down the "report an exception" path instead of rethrowing them. It also makes a slight change of rethrowing any early errors that are not SyntaxErrors, instead of converting early ReferenceErrors into SyntaxErrors.
@domenic domenic mentioned this issue Dec 15, 2015
Merged
domenic added a commit that referenced this issue Dec 15, 2015
@domenic
Fix importScripts() script execution
9fcce82 
This fixes #193, which notes that importScripts() previously sent errors down the "report an exception" path instead of rethrowing them. It also makes a slight change of rethrowing any early errors that are not SyntaxErrors, instead of converting early ReferenceErrors into SyntaxErrors.
domenic added a commit that referenced this issue Dec 15, 2015
@domenic
Fix importScripts() script execution
dd665d7 
This fixes #193, which notes that importScripts() previously sent errors down the "report an exception" path instead of rethrowing them. It also makes a slight change of rethrowing any early errors that are not SyntaxErrors, instead of converting early ReferenceErrors into SyntaxErrors.
domenic added a commit that referenced this issue Dec 16, 2015
@domenic
Fix importScripts() script execution
019e30a 
This fixes #193, which notes that importScripts() previously sent errors down the "report an exception" path instead of rethrowing them. It also makes a slight change of rethrowing any early errors that are not SyntaxErrors, instead of converting early ReferenceErrors into SyntaxErrors.
domenic added a commit that referenced this issue Dec 17, 2015
@domenic
Fix importScripts() script execution
f07ab77 
This fixes #193, which notes that importScripts() previously sent errors down the "report an exception" path instead of rethrowing them. It also makes a slight change of rethrowing any early errors that are not SyntaxErrors, instead of converting early ReferenceErrors into SyntaxErrors.
domenic added a commit that referenced this issue Dec 18, 2015
@domenic
Fix importScripts() script execution
71e7699 
This fixes #193, which notes that importScripts() previously sent errors down the "report an exception" path instead of rethrowing them. It also makes a slight change of rethrowing any early errors that are not SyntaxErrors, instead of converting early ReferenceErrors into SyntaxErrors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@domenic domenic

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@domenic @annevk