Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document which request fields are required #949

Closed
jyasskin opened this issue Oct 8, 2019 · 4 comments
Closed

Document which request fields are required #949

jyasskin opened this issue Oct 8, 2019 · 4 comments
Labels
clarification Standard could be clearer

Comments

@jyasskin
Copy link
Member

jyasskin commented Oct 8, 2019

It's not clear from https://fetch.spec.whatwg.org/#concept-request which fields another specification needs to set in order to fetch the request. I believe https://www.w3.org/TR/appmanifest/#obtaining forgets to set the client as a result.

I think the required fields are:

  • client (because fetch uses "request’s client’s global object" without checking whether the client is null)
  • URL
@annevk
Copy link
Member

annevk commented Oct 9, 2019

Hmm, client should maybe be optional, though App Manifest ought to set it. I'd also expect mode/destination to typically be set, even though they have defaults at the moment.

This is a duplicate of #186 of sorts.

@jyasskin
Copy link
Member Author

Yep, and the "write a create-a-request algorithm" suggestion in #907 (comment) (where you also thought client should not be optional 😉). FWIW, I think it will be easier to obey the "how to use fetch from other specs" advice if it's in a separate section than if it's mixed into the definitions of the fields.

@annevk
Copy link
Member

annevk commented Oct 14, 2019

Yeah, not being optional, but being able to handle null is probably what's needed.

@annevk annevk added the clarification Standard could be clearer label Jan 30, 2021
@annevk
Copy link
Member

annevk commented Mar 11, 2021

Let's fold this into #1143.

@annevk annevk closed this as completed Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification Standard could be clearer
Development

No branches or pull requests

2 participants