Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce abortSignal.throwIfAborted() #1034

Merged
merged 2 commits into from
Dec 10, 2021
Merged

Conversation

domenic
Copy link
Member

@domenic domenic commented Nov 23, 2021

Closes #927.

(See WHATWG Working Mode: Changes for more details.)


Preview | Diff

@domenic domenic added the topic: aborting AbortController and AbortSignal label Nov 23, 2021
@josepharhar
Copy link
Contributor

Copy link
Contributor

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be helpful to save some boilerplate. +1

jasnell added a commit to jasnell/node that referenced this pull request Nov 24, 2021
@domenic
Copy link
Member Author

domenic commented Nov 24, 2021

Awesome :). If we can take Mozilla as interested per @annevk's enthusiasm, then this is ready to merge as soon as someone writes tests.

@annevk annevk added the needs tests Moving the issue forward requires someone to write tests label Nov 24, 2021
jasnell added a commit to jasnell/node that referenced this pull request Dec 2, 2021
@annevk annevk force-pushed the abortsignal-throwifaborted branch from d001912 to 0645ef6 Compare December 6, 2021 10:11
@annevk annevk added the addition/proposal New features or enhancements label Dec 6, 2021
@jasnell
Copy link
Contributor

jasnell commented Dec 7, 2021

@domenic .. WPT test PR here: web-platform-tests/wpt#31947

domenic pushed a commit to web-platform-tests/wpt that referenced this pull request Dec 8, 2021
@domenic domenic removed the needs tests Moving the issue forward requires someone to write tests label Dec 8, 2021
@domenic
Copy link
Member Author

domenic commented Dec 8, 2021

Tests are merged; merge at will @annevk!

@annevk annevk merged commit cfe2f1e into main Dec 10, 2021
@annevk annevk deleted the abortsignal-throwifaborted branch December 10, 2021 08:39
andreubotella pushed a commit to andreubotella/deno that referenced this pull request Dec 10, 2021
andreubotella pushed a commit to andreubotella/deno that referenced this pull request Dec 10, 2021
lucacasonato pushed a commit to denoland/deno that referenced this pull request Dec 10, 2021
jasnell added a commit to nodejs/node that referenced this pull request Dec 10, 2021
Refs: whatwg/dom#1034
Signed-off-by: James M Snell <[email protected]>

PR-URL: #40951
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@cdumez
Copy link

cdumez commented Dec 10, 2021

Should probably be added to web-platform-tests/interfaces/dom.idl too.

@annevk
Copy link
Member

annevk commented Dec 10, 2021

@cdumez that should happen automatically through a bot, but it might take a day or so.

@jasnell
Copy link
Contributor

jasnell commented Dec 10, 2021

PR landed in node.js! support will roll out in the next 17.x release

danielleadams pushed a commit to nodejs/node that referenced this pull request Dec 14, 2021
Refs: whatwg/dom#1034
Signed-off-by: James M Snell <[email protected]>

PR-URL: #40951
Reviewed-By: Benjamin Gruenbaum <[email protected]>
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Dec 20, 2021
… a=testonly

Automatic update from web-platform-tests
Tests for abortSignal.throwIfAborted()

Follows whatwg/dom#1034.
--

wpt-commits: b03df354b93b285fe1764d567b7c1a074df4a808
wpt-pr: 31947
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
Refs: whatwg/dom#1034
Signed-off-by: James M Snell <[email protected]>

PR-URL: nodejs#40951
Reviewed-By: Benjamin Gruenbaum <[email protected]>
targos pushed a commit to nodejs/node that referenced this pull request Aug 1, 2022
Refs: whatwg/dom#1034
Signed-off-by: James M Snell <[email protected]>

PR-URL: #40951
Reviewed-By: Benjamin Gruenbaum <[email protected]>
targos pushed a commit to nodejs/node that referenced this pull request Aug 1, 2022
Refs: whatwg/dom#1034
Signed-off-by: James M Snell <[email protected]>

PR-URL: #40951
Reviewed-By: Benjamin Gruenbaum <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
Refs: whatwg/dom#1034
Signed-off-by: James M Snell <[email protected]>

PR-URL: nodejs/node#40951
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addition/proposal New features or enhancements topic: aborting AbortController and AbortSignal
Development

Successfully merging this pull request may close these issues.

Encourage use of AbortError for cancellation?
5 participants