-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce abortSignal.throwIfAborted() #1034
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be helpful to save some boilerplate. +1
Refs: whatwg/dom#1034 Signed-off-by: James M Snell <[email protected]>
Awesome :). If we can take Mozilla as interested per @annevk's enthusiasm, then this is ready to merge as soon as someone writes tests. |
Refs: whatwg/dom#1034 Signed-off-by: James M Snell <[email protected]>
d001912
to
0645ef6
Compare
@domenic .. WPT test PR here: web-platform-tests/wpt#31947 |
Tests are merged; merge at will @annevk! |
Refs: whatwg/dom#1034 Signed-off-by: James M Snell <[email protected]> PR-URL: #40951 Reviewed-By: Benjamin Gruenbaum <[email protected]>
Should probably be added to web-platform-tests/interfaces/dom.idl too. |
@cdumez that should happen automatically through a bot, but it might take a day or so. |
PR landed in node.js! support will roll out in the next 17.x release |
Refs: whatwg/dom#1034 Signed-off-by: James M Snell <[email protected]> PR-URL: #40951 Reviewed-By: Benjamin Gruenbaum <[email protected]>
… a=testonly Automatic update from web-platform-tests Tests for abortSignal.throwIfAborted() Follows whatwg/dom#1034. -- wpt-commits: b03df354b93b285fe1764d567b7c1a074df4a808 wpt-pr: 31947
Refs: whatwg/dom#1034 Signed-off-by: James M Snell <[email protected]> PR-URL: nodejs#40951 Reviewed-By: Benjamin Gruenbaum <[email protected]>
Refs: whatwg/dom#1034 Signed-off-by: James M Snell <[email protected]> PR-URL: #40951 Reviewed-By: Benjamin Gruenbaum <[email protected]>
Refs: whatwg/dom#1034 Signed-off-by: James M Snell <[email protected]> PR-URL: #40951 Reviewed-By: Benjamin Gruenbaum <[email protected]>
Refs: whatwg/dom#1034 Signed-off-by: James M Snell <[email protected]> PR-URL: nodejs/node#40951 Reviewed-By: Benjamin Gruenbaum <[email protected]>
Closes #927.
(See WHATWG Working Mode: Changes for more details.)
Preview | Diff