Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use only lowercase for all ids. #94

Closed
ArkadiuszMichalski opened this issue Oct 20, 2015 · 9 comments
Closed

Use only lowercase for all ids. #94

ArkadiuszMichalski opened this issue Oct 20, 2015 · 9 comments

Comments

@ArkadiuszMichalski
Copy link
Contributor

I see that some of id was changed and using uppercase:

concept-DTL-tokens (was concept-dtl-tokens)
concept-DTL-update (was concept-dtl-update)
concept-NodeIterator-traverse (was concept-nodeiterator-traverse)
concept-traversal-whatToShow (was concept-traversal-whattoshow)

dom-Range-toString (previouse was better dom-range-stringifier)
stringification-behavior (previouse was better dom-domtokenlist-stringifier)

Maybe use one convention (all lowercase letters)?

@annevk
Copy link
Member

annevk commented Oct 20, 2015

Yeah, could you create a PR perhaps?

@ArkadiuszMichalski
Copy link
Contributor Author

Is there any fast instruction how do this correctly?

@annevk
Copy link
Member

annevk commented Oct 20, 2015

Edit dom.bs and change the incorrect IDs. I can handle the generation of the other file.

@ArkadiuszMichalski
Copy link
Contributor Author

#95

@annevk annevk closed this as completed in 27b1696 Oct 20, 2015
@ArkadiuszMichalski
Copy link
Contributor Author

Hmm, now see there is more, I listing all here and when finish DOM analize, then I make next PR for all:
#concept-PI-target
#concept-Text-split
#concept-CD-substring
#concept-CD-replace
#concept-CD-data
#concept-NamedNodeMap-element
#concept-NamedNodeMap-attribute
#concept-DocumentFragment-host
#concept-getElementsByClassName
#concept-getElementsByTagNameNS
#concept-getElementsByTagName
#concept-MO-queue
#concept-MO-callback

@domenic
Copy link
Member

domenic commented Oct 25, 2015

Why change these? Doing so breaks incoming links for no benefit.

@ArkadiuszMichalski
Copy link
Contributor Author

Will be one consistent style (beetwen specs), and in the past all this IDs were lowercase, don't now why was change, I see in some place (like MDN) that this changing mixing case breaks actual references, so backing to previouse will fix them... but if this new style must be like this then OK, change is no need.

Above I mean only use lowercase for all, don't change them in other way.

@domenic
Copy link
Member

domenic commented Oct 25, 2015

Well, if it un-breaks links, it is probably good.

@annevk
Copy link
Member

annevk commented Oct 25, 2015

Yeah, this would be a good change. Please make it @ArkadiuszMichalski!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants