Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test parser against WebGPU's CTS parser tests #45

Open
mighdoll opened this issue Nov 29, 2024 · 2 comments
Open

Test parser against WebGPU's CTS parser tests #45

mighdoll opened this issue Nov 29, 2024 · 2 comments
Milestone

Comments

@mighdoll
Copy link
Contributor

No description provided.

@mighdoll mighdoll added this to the M1 milestone Nov 29, 2024
@github-project-automation github-project-automation bot moved this to Unprioritized in wgsl-linker Nov 29, 2024
@mighdoll
Copy link
Contributor Author

cc: @k2d222, we can start from your wesl-testsuite PR and adapt that... or anything more recent that you might have?

@mighdoll mighdoll changed the title Test linker parser against WebGPU's CTS parser tests Test parser against WebGPU's CTS parser tests Nov 29, 2024
@mighdoll mighdoll moved this from Unprioritized to Todo in wgsl-linker Nov 29, 2024
@k2d222
Copy link

k2d222 commented Nov 30, 2024

I did improve the tests extraction but didn't push that just yet. I managed to extract tests expectations from the CTS without relying on Dawn. I suggest you use the current PR if you want to move forward right away, because I am travelling this week and won't be able to finish that job right now.

Also worth noting: the tests currently in PR wesl-testsuite#4 are those that match query webgpu/shader/validation/parse/*. The problem is some of these tests are not necessarily syntactic, e.g. shadowing builtins, ensuring that literals don't overflow, strict parsing of attributes. Some also could clash with WESL extensions. So while these tests are helpful to detect bugs, they would probably need to be filtered for your implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants