Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: add possibility to (next to weight) also include RPE (rate of perceived exertion) to each set of weight lifting #479

Closed
doodhout opened this issue Aug 9, 2020 · 20 comments · Fixed by #546
Labels
effort: medium Medium effort/complexity good first issue
Milestone

Comments

@doodhout
Copy link

doodhout commented Aug 9, 2020

This is because not only the performed sets x reps x weight is important, the RPE is very important in the sense that it tracks the difficulty of the performed set and serves the purpose of having a complete log of the session. If RPE is missing, then the log being incomplete isn't very useful.

RPE is expressed in a number from 1 to 10; 1 being very easy and 10 being the most intense a movement could be without failing. RPE with halves is sometimes used, e.g. RPE of 7,5; 8,5; 9,5 to have slightly more values to add more nuance.

Currently the following can be defined for a set: number of reps, weight and unit of weight. I would like RPE to be added to that, with the possibility to use a number from this set: [1; 2; 3; 4; 5; 6; 7; 7,5; 8; 8,5; 9; 9,5; 10]. I realise that the numbers 1 till 5 are not very useful, but I'd add them just for completeness' sake.

@rolandgeider
Copy link
Member

Good idea. I had also thought to add Reps In Reserve or something similar. The difficulty would be to present it in a way that is not overwhelming when somebody does not want wo use it

@rolandgeider
Copy link
Member

Another Todo more or less related to this: streamline the log overview to be more useful

@rolandgeider rolandgeider added effort: medium Medium effort/complexity good first issue labels Aug 26, 2020
@rolandgeider
Copy link
Member

What needs to be done here:

  • change the Setting model and add a new field (either reps_in_reserve or rpe) and add the appropriate list as possible values.
  • update the crispy form to show them
  • show the values on the workout overview

@SkyNetIndustry
Copy link

Hello,
If this is still open, I'd like contribute it.

@rolandgeider
Copy link
Member

Hi! Yes it's still open, you can go ahead

@SkyNetIndustry
Copy link

You indicated pty=True, but your platform doesn't support the 'pty' module!

Any help? The second option docker :D

@rolandgeider
Copy link
Member

🤔🤔

which docker are you using the devel image?

@SkyNetIndustry
Copy link

I got it started :)

@doodhout
Copy link
Author

Good idea. I had also thought to add Reps In Reserve or something similar. The difficulty would be to present it in a way that is not overwhelming when somebody does not want wo use it

Yeah RPE and RIR (reps in reserve) are the same metric really, so any one of those is fine.

Thanks for starting this!

@SkyNetIndustry
Copy link

If I understand correctly, is it necessary to change this form?
Screenshot_2

@rolandgeider
Copy link
Member

Yes, after changing the Settings and the WorkoutLog models, take a look at WorkoutLogFormHelper in manager/forms.py

@rolandgeider
Copy link
Member

BTW, I would prefer to go with Reps In Reserve, as I find it more intuitive to say "I could have done two reps more". This only changes the possible values in the dropdown, which would go from 4.5 to 1

@doodhout
Copy link
Author

doodhout commented Oct 13, 2020

@rolandgeider RIR is an excellent choice! Would you like to have "half" reps in reserve? It's usual to use that in RPE-scale (I couldn't have completed another rep, but maybe if the last rep was heavier I could have still done it), but in RIR-scale I don't know whether it has the same usefulness.

@rolandgeider
Copy link
Member

Mhhh, I see what you mean. I guess it depends on what meaning you'd give to the half reps.

@doodhout
Copy link
Author

doodhout commented Oct 13, 2020

Technically I don't think it's of use to allow half reps in reserve, because reps cannot be counted in halves. It does however add nuance to the number, because 1 RIR can mean anything from "just barely 1" to "certainly 1 and maybe two but not sure". Meh, first-world problems.

@rolandgeider
Copy link
Member

1 RIR can mean anything from "just barely 1" to "certainly 1 and maybe two but not sure". Meh, first-world problems.

Exactly. I'd vote to leave the halves in 😄

@rolandgeider rolandgeider linked a pull request Nov 5, 2020 that will close this issue
1 task
@rolandgeider rolandgeider added this to the 2.0 milestone Nov 5, 2020
@rolandgeider
Copy link
Member

This is merged and is available on master 🕺🏻 I'll update the server the next days

@addyhub
Copy link

addyhub commented Jul 19, 2021

You indicated pty=True, but your platform doesn't support the 'pty' module!

Any help? The second option docker :D

Hi so I'm getting the same issue
You indicated pty=True, but your platform doesn't support the 'pty' module!
How did u fix this?

@SkyNetIndustry
Copy link

You indicated pty=True, but your platform doesn't support the 'pty' module!
Any help? The second option docker :D

Hi so I'm getting the same issue
You indicated pty=True, but your platform doesn't support the 'pty' module!
How did u fix this?

Hi addyhub
I learned the docker and used it to code. Since then, only docker 😄 🐋

@addyhub
Copy link

addyhub commented Jul 19, 2021

You indicated pty=True, but your platform doesn't support the 'pty' module!

I'm having this issue any fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: medium Medium effort/complexity good first issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@rolandgeider @doodhout @addyhub @SkyNetIndustry and others