Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs generated for list don't support removal of headers #111

Open
sburnicki opened this issue May 18, 2017 · 3 comments
Open

Tabs generated for list don't support removal of headers #111

sburnicki opened this issue May 18, 2017 · 3 comments

Comments

@sburnicki
Copy link

sburnicki commented May 18, 2017

When I generate tabs from a list like this:

  <tabs nav-style="tabs" v-model="activeTab">
    <tab v-for="(myTab) in myTabs" v-bind:header="myTab.name">
   ...

Then I can add and remove new tabs. However, on removal (like this.myTabs.splice(0, 1)) the headers don't get properly updated.

I guess this is because they are explicitly added on created, but not being removed in beforeDestroy in the Tab component

@laurenswarson
Copy link

Same error!

@Toilal
Copy link

Toilal commented Jun 19, 2017

Same here.

@Toilal
Copy link

Toilal commented Jun 19, 2017

I wrote a Pull Request, but i'm not sure this repository is still maintained :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants