Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer loopback multicast address from runtime.GOOS. #99

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

lthibault
Copy link
Collaborator

Fixes #96.

I went through several iterations of this in which I tried to make clever use of net.Interfaces(), but ultimately gave up and went with a static switch statement. This should be correct most of the time, and we can add cases to the switch statement as needed. I'm not sure how many of these platforms we'll end up supporting, anyway.

I'm open to ideas.

@lthibault lthibault added the bug Something isn't working label Mar 30, 2023
@lthibault lthibault self-assigned this Mar 30, 2023
@lthibault lthibault merged commit cc13a4a into master Mar 30, 2023
@lthibault lthibault deleted the enhancement/per-os-multicast-iface branch March 30, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set default discovery multiaddr depending on the OS
2 participants