Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add streaming interface for pubsub publishers #61

Open
lthibault opened this issue Nov 14, 2022 · 0 comments
Open

Add streaming interface for pubsub publishers #61

lthibault opened this issue Nov 14, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@lthibault
Copy link
Collaborator

It is common for pubsub.Topic.Publish() to be called repeatedly in order to stream events to a topic. However, this method blocks until the RPC call round-trips, which degrades performance. While we currently expose PublishAsync, the proper management of stream state is a non-trivial task, so we should expose a NewStream() method that integrates with CASM's pkg/util/stream.

It may be worthwhile to reuse code from #59.
@lthibault lthibault added the enhancement New feature or request label Nov 14, 2022
@lthibault lthibault mentioned this issue Dec 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lthibault