Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paper: add plots to illustrate some of the package's functionality #23

Closed
paulrougieux opened this issue Jan 31, 2024 · 2 comments
Closed
Assignees
Labels
joss review related issues related to the review process for publication

Comments

@paulrougieux
Copy link

Comments on JOSS_paper/paper.md in the version available at commit
11a34a0 “add paper preprint” by Flaminia Catalli.

decision makers (DMs) Acronym is only used two other times. Just keep it as a word
"decision makers" it's less confusing.

Can you illustrate the paper with a couple of plots? See for example the plots done in
the JOSS paper describing the Coinr package.

There are several plotting functions in mcda/utils.py

plot_norm_scores_without_uncert
plot_non_norm_scores_without_uncert
plot_mean_scores
plot_mean_scores_iterative

These functions could be used with sample data to generate a plot illustrating some of
the functionality of the package.

This is related to openjournals/joss-reviews#6190

Copy link

Hello @paulrougieux, thank you for submitting an issue. We will take care of it.

@Flaminietta Flaminietta added the joss review related issues related to the review process for publication label Feb 2, 2024
@mspada
Copy link
Collaborator

mspada commented Jul 2, 2024

Hi @paulrougieux,
your suggestion is valid, but it fits well to a library with plotting methods, which is not the case of ProMCDA.
By the way, no function of ProMCDA can be called by the user like e.g. promcda.plot_mean_scores yet.
Instead, it generates basic figures in the browser as well as in the output folder for quick visualization.
For these reasons we would prefer to leave the text as it is and consider improving the visualization functionality of ProMCDA in the process of rebuilding it as a library.
Would you be fine with this decision?

@mspada mspada closed this as completed Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
joss review related issues related to the review process for publication
Projects
None yet
Development

No branches or pull requests

4 participants