Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

text-* css classes don't pass colour contrast #319

Closed
cfarquharson opened this issue Dec 4, 2013 · 3 comments
Closed

text-* css classes don't pass colour contrast #319

cfarquharson opened this issue Dec 4, 2013 · 3 comments
Milestone
1.0.0

Comments

@cfarquharson
Copy link
Member

Every colour except the red one, fail color contrast requirements against the background color
text-color
@masterbee
Copy link
Member

@cfarquharson , thanks for this. My PR to adjust this has already been merged in Twitter Bootstrap so this issue is resolved upstream for Version 3.0.3 of twitter.

twbs/bootstrap#11432. My PR adjusted the base hex values of the text so on the grey.

@thomasgohard
Copy link
Member

@masterbee Do we need to add overrides in our CSS? Or will version 3.0.3 of Bootstrap be released and integrated before launch?

@masterbee
Copy link
Member

Closed since Bootstrap version was bumped to 3.0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
3 participants
@masterbee @thomasgohard @cfarquharson