Fixed toggle column bug with complex header #6124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
wenzhixin
force-pushed
the
fix/3213
branch
2 times, most recently
from
fe1d815
to
56bc3c3
Compare
|
The columns looks good for me, but the right border is broken. |
How do you reproduce the problem? |
|
Just hide one column (no matter which one) |
|
That's not happening to me. It's working as expected. Windows and Chrome Version 100.0.4896.127 |
|
I only can reproduce it on firefox (99.0.1) on macOS (12.3). |
I think it's a problem with the browser and not related to the fixed issue. @UtechtDustin |
|
It seems firefox is quite buggy with |
UtechtDustin
approved these changes
May 6, 2022
This was referenced May 12, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔Type of Request
🔗Resolves an issue?
Fix #3213
📝Changelog
Fixed toggle column bug with complex headers.
💡Example(s)?
Before: https://live.bootstrap-table.com/code/wenzhixin/11375
After: https://live.bootstrap-table.com/code/wenzhixin/11376
Before: https://live.bootstrap-table.com/code/wenzhixin/11377
After: https://live.bootstrap-table.com/code/wenzhixin/11378
☑️Self Check before Merge