Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ipython to extra dependencies #685

Closed
sobolevn opened this issue Mar 11, 2019 · 7 comments
Closed

Move ipython to extra dependencies #685

sobolevn opened this issue Mar 11, 2019 · 7 comments

Comments

@sobolevn
Copy link
Member

ipython is not required anywhere except local machine. Moreover, not all developers use it.
Maybe we can move to some new extra dependency section?

We can even create more of them later.

@sobolevn sobolevn changed the title Move ipython to extra dependency Move ipython to extra dependencies Mar 11, 2019
@DmytroLitvinov
Copy link
Collaborator

Hello @sobolevn .

Personally I, use it at shell and shell_plus managements commands.
It is very useful, because it has autocomplete and it loads all of the models.

I think we can use it under dev-dependencies.

@DmytroLitvinov
Copy link
Collaborator

DmytroLitvinov commented Mar 11, 2019

I agree with you that it is not required package under main dependencies(production probably), but for local machine(dev) it is very useful.
What do you think?

@sobolevn
Copy link
Member Author

Same, I just try to find the ways to speed up the docker builds inside the CI.

@sobolevn
Copy link
Member Author

https://github.com/sdispater/poetry#extras

@sobolevn
Copy link
Member Author

» poetry install -E ipython
Installing dependencies from lock file


Package operations: 13 installs, 0 updates, 0 removals

  - Installing ipython-genutils (0.2.0)
  - Installing parso (0.3.4)
  - Installing ptyprocess (0.6.0)
  - Installing pygments (2.3.1)
  - Installing wcwidth (0.1.7)
  - Installing appnope (0.1.0)
  - Installing backcall (0.1.0)
  - Installing jedi (0.13.3)
  - Installing pexpect (4.6.0)
  - Installing pickleshare (0.7.5)
  - Installing prompt-toolkit (2.0.9)
  - Installing traitlets (4.3.2)
  - Installing ipython (7.3.0)

(.venv) ~/Documents/PyCharmProjects/...  master ✗
» poetry install -E docs
Installing dependencies from lock file


Package operations: 10 installs, 0 updates, 0 removals

  - Installing pyparsing (2.3.1)
  - Installing alabaster (0.7.12)
  - Installing babel (2.6.0)
  - Installing imagesize (1.1.0)
  - Installing packaging (19.0)
  - Installing sphinxcontrib-websupport (1.1.0)
  - Installing pockets (0.7.2)
  - Installing sphinx (1.8.5)
  - Installing sphinx-autodoc-typehints (1.6.0)
  - Installing sphinxcontrib-napoleon (0.7)```

@sobolevn
Copy link
Member Author

There are several problems:

  1. poetry has bugs related to extras How can I specify differing sets of dependency extras for each of my project's extras? python-poetry/poetry#834 and Automatically add extras entry for --optional python-poetry/poetry#772
  2. we need to somehow pass these --extra params to docker build
  3. this needs to work differently for different envs (so, clearly no ipython on prod)

@sobolevn
Copy link
Member Author

I will put this on hold for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants