Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat with flake8 >= 6 #281

Closed
AdrianusWest opened this issue Nov 24, 2022 · 8 comments
Closed

Compat with flake8 >= 6 #281

AdrianusWest opened this issue Nov 24, 2022 · 8 comments

Comments

@AdrianusWest
Copy link

"SolverProblemError

Because flake8-broken-line (0.6.0) depends on flake8 (>=3.5,<6) and no versions of flake8-broken-line match >0.6.0,<0.7.0, flake8-broken-line (>=0.6.0,<0.7.0) requires flake8 (>=3.5,<6). So, because project depends on both flake8 (^6.0.0) and flake8-broken-line (^0.6.0), version solving failed."

@degenaro
Copy link

Any workaround suggestions until this issue is resolved? Tried removing flake8-broken-line from .pre-commit-config.yaml which only led to more complications.

@sobolevn
Copy link
Member

Sorry, there's nothing I can do. Because flake8@6 dropped 3.7 support

@degenaro
Copy link

If flake8 dropped support for 3.7, why not do the same? those who still care can an use old level.

@AdrianusWest
Copy link
Author

What's the problem with switching to a new version of python anyway?

@degenaro
Copy link

I have no problem with folks wanting to continue on older versions of code for variety of reasons, for example organizational intertia . But folks who want to move forward should not be blocked.

@sshishov
Copy link

sshishov commented Dec 8, 2022

I think that the people who want to stay on old version of python, they are good to use old version of flake8.
We should just deprecate the usage of old python version and bump the major version, what happened recently with flake8.

@johnthagen
Copy link

johnthagen commented May 1, 2023

For those considering migrating to Ruff, here is the issue request asking for flake8-broken-line to be implemented there:

@terencehonles
Copy link

This should be fixed by #307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants