Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent invalid column size count #830

Merged
merged 1 commit into from
Oct 27, 2024
Merged

fix: prevent invalid column size count #830

merged 1 commit into from
Oct 27, 2024

Conversation

wellwelwel
Copy link
Owner

Fixes #829.

Copy link
Contributor

🚀 Benchmark Results

Summary
  🐷 Poku (dc4b6ce) ran
    2.58 ± 0.12 times faster than Mocha (10.7.3)
    5.53 ± 0.28 times faster than Vitest (2.1.3)
    5.89 ± 0.27 times faster than Jest (29.7.0)

🔬 Native Test Runners

🐢 Comparative with Node.js

Summary
  Node.js ran
    1.12 ± 0.03 times faster than 🐷 Poku (dc4b6ce)

🍞 Comparative with Bun

Summary
  Bun ran
    3.17 ± 0.22 times faster than 🐷 Poku (dc4b6ce)

Note

📘 For more details and how the benchmarks are carried out, see the benchmark section.

Copy link

codecov bot commented Oct 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.12%. Comparing base (08f7867) to head (dc4b6ce).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #830   +/-   ##
=======================================
  Coverage   99.12%   99.12%           
=======================================
  Files          36       36           
  Lines        1824     1825    +1     
  Branches       10       10           
=======================================
+ Hits         1808     1809    +1     
  Misses          8        8           
  Partials        8        8           
Flag Coverage Δ
linux 99.01% <100.00%> (+<0.01%) ⬆️
osx 99.06% <100.00%> (+<0.01%) ⬆️
windows 99.01% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wellwelwel wellwelwel marked this pull request as ready for review October 27, 2024 03:11
@wellwelwel wellwelwel merged commit 2d00338 into main Oct 27, 2024
23 checks passed
@wellwelwel wellwelwel deleted the hr branch October 27, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RangeError: Invalid count value in Write.hr function
1 participant