-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate CLI flags #647
Comments
Hey, @mrazauskas 🙋🏻♂️ I'd have no problem patterning the As for validation, it's a good idea. |
Sure. This issue is about validation only. The rest is totally up to you. Since that is opinionated and also depends on how you see Poku's future. |
I understand this is not a priority right now. Just to draw you attention: not only flag names, but also their values need validation; the same is applicable for config file options. For example, imagine some option being removed / renamed / changed its behaviour. Perhaps it is worth to keep this issue open? |
In a way, this functionality would frequently imply breaking changes. So, to have more flexibility, I released it as "Early Development" and documented some plans for the poku/website/docs/documentation/poku/options/enforce.mdx Lines 27 to 29 in 3cb5a00
Also: poku/website/docs/documentation/poku/options/enforce.mdx Lines 39 to 41 in 3cb5a00
For now, I'm using the documentation itself as if it were an issue (with the idea of emphasizing that this feature is still under development). Honest question, do you think this is a bad idea? |
About this, I tend to take versioning pretty carefully, for example, to make it easier to migrate on camel case, I've allowed both kebab and camel cases until a new major version is actually released. Despite that, the intention is for the |
Thanks for CLI improvements!
Here is another idea. I have noticed that it is too easy to make a mistake like this:
poku --failFast
. ThefailFast
is primarily documented using camel case (look at TOC, or heading of the page). Or someone (like me) might be used to run tests with--failFast
.It would be useful to see some error like: Unknown flag
--failFast
.Edit: And another mistake I just made:
poku --paralel
.Support for camel case flags is another feature, but I will mention it here too. Interestingly
tsc
supports only camel case flags. That simplifies documentation of compiler config options and CLI flags.The text was updated successfully, but these errors were encountered: