-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discovery: Button variants and styled-system PoC #8304
Comments
Proof of concept started in the It seems it would be easily changeable to using this library if it is of interest, but for now I want to wait and see where things are headed with the new palette, which will certainly dictate what our new "atom" components will look like and if it's worth switching over. I personally find it a very readable way of declaring components, whilst insuring their styles are aligned. It is still possible to declare your own styles if you decide you need something other than the available variants, just by using In this example, code changed in this way: Before:
After:
or even, as I made
(in this case, These of course are all suggestions, the way we go ahead with the different scales would depend on our needs. All in all, It was a promising first array into looking into styled-system, and it would be an interesting avenue to go down when we have a more solid understanding of our new styles. |
Because of all the refactoring of the button component going on and new designs (Exhibition Guides, Concepts) suggesting different versions of new buttons, I want to explore how complex/beneficial it would be to start using styled-system on top of styled-components. It allows for variants, which is a simpler way of declaring components in specific styles, hopefully keeping them aligned throughout the platforms instead of allowing for too much flexibility.
I'm exploring this one as I've used it before and it seems to match what are needs are in this moment. As they say:
This discovery will also ensure it still allows some flexibility when there are edge cases.
The text was updated successfully, but these errors were encountered: