Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The storage service should support using checksums that aren't SHA-256 #900

Closed
alexwlchan opened this issue Jul 19, 2021 · 1 comment · Fixed by #920
Closed

The storage service should support using checksums that aren't SHA-256 #900

alexwlchan opened this issue Jul 19, 2021 · 1 comment · Fixed by #920
Assignees
Labels

Comments

@alexwlchan
Copy link
Contributor

Quoting the BagIt RFC:

Starting with BagIt 1.0, bag creation and validation tools MUST
support the SHA-256 and SHA-512 algorithms [RFC6234] and SHOULD
enable SHA-512 by default when creating new bags. For backwards
compatibility, implementers SHOULD support MD5 [RFC1321] and SHA-1
[RFC3174]. Implementers are encouraged to simplify the process of
adding additional manifests using new algorithms to streamline the
process of in-place upgrades.

Right now we only support SHA-256. We should add support for other checksum algorithms.

@alexwlchan alexwlchan self-assigned this Jul 19, 2021
@alexwlchan
Copy link
Contributor Author

Failure modes we need to consider:

  • There's no SHA-256/SHA-512 manifest
  • The manifests have different entries
  • One manifest is valid but the other isn't
  • We have inconsistent manifests, e.g. a MD5 manifest and a SHA256 tag manifest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant